feat: add audit options #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainchen
reviewed
Jul 25, 2019
lib/tasks/code_quality.rake
Outdated
| @@ -36,9 +36,11 @@ namespace :code_quality do | |||
|
|
|||
| desc "bundler audit" | |||
| task :bundler_audit => :prepare do |task| | |||
| options = options_from_env(:audit_options) | |||
There was a problem hiding this comment.
the env key should be named as bundler_audit_options
There was a problem hiding this comment.
please update the README to expose there is an option for bundler_audit task, should describe what kind of options would be used
iceskyl
force-pushed
the
add-audit-options
branch
from
f4e1a42 to
904d6ec
Compare
rainchen
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It need to add --ignore option to
bundle audit checkmethod because some vulnerabilities like CVE-2015-9284 fixed by other gem but not itself.